Jump to content


Photo

Yush bug and fix


    8 replies to this topic

    #1 ___

    ___

      Advanced Member

    • Members
    • PipPipPip
    • 40 posts

      Posted 05 April 2015 - 04:37 PM

      I don't have a github account or know anything about using it (and I don't want to).  However I was frustrated trying to use a feature of Yush and spent hours trying to work around it then just finally identifying and fixing the issue so here you go:

       

      When the yush press command was used the last key would be held down for eternity.  I would put:

          ['Alt+1'] = 'gs c smn carbuncle;yush press alt 9',
      

      In my macro to swap to the pacts table when I summoned say carbuncle.  It would do so but then if I held down control after it'd automatically hit control 9.  For me that'd unsummon the avatar.  Which was unusable.  I'd also notice 9 just seemed held down until I would

      lua r yush
      

      So I looked through the Yush.lua source and found this:

          elseif command == 'press' then
              keys = keys + S(args):map(string.lower)
              check()
      

      I did this to fix it after tying tons of other stuff in other areas to try to fix it:

          elseif command == 'press' then
      	keysorig = keys
              keys = keys + S(args):map(string.lower)
              check()
              keys = keysorig 
      

      I'm sure this is not a perfect solution.  It does seem to work though I have to add wait timers to my code to not get "unable to cast spells at this time" messages for some reason:

          ['Alt+1'] = 'gs c smn carbuncle;wait 1.3;yush press alt 9',
      

      Now it works perfectly.  Unsure of any hidden consequences to this change however.  Sharing so anyone else wanting to use the yush press command without this debilitating bug can once it's patched.  Thanks for making YUSH though it's a great addon otherwise and I enjoy using it.



      #2 Iryoku

      Iryoku

        Advanced Member

      • Windower Staff
      • 488 posts

        Posted 05 April 2015 - 08:21 PM

        Is there a reason you didn't submit a pull request for this?



        #3 ___

        ___

          Advanced Member

        • Members
        • PipPipPip
        • 40 posts

          Posted 05 April 2015 - 09:11 PM

          I don't know what a pull request is, something github?



          #4 Iryoku

          Iryoku

            Advanced Member

          • Windower Staff
          • 488 posts

            Posted 05 April 2015 - 09:16 PM

            Yes, here's what GitHub has to say about them: https://help.github....-pull-requests/



            #5 ___

            ___

              Advanced Member

            • Members
            • PipPipPip
            • 40 posts

              Posted 05 April 2015 - 09:24 PM

              I already explained I have never used it and don't want to, I have successfully avoided working with other programmers for over 9 years for reasons like this, I don't want to jump through protocol hoops to do coding.  Here is a bug fix, if you want to use it great.  If not then don't.  If I commonly made code contributions to other places I might get one but this is the first time I've ever submitted a bug to someone else and I'm not going to learn all of github for two lines of code.



              #6 Arcon

              Arcon

                Advanced Member

              • Windower Staff
              • 1189 posts
              • LocationMunich, Germany

              Posted 06 April 2015 - 12:21 PM

              How edgy.



              #7 ___

              ___

                Advanced Member

              • Members
              • PipPipPip
              • 40 posts

                Posted 06 April 2015 - 06:17 PM

                You've suceeded in deterring me from submitting future bug fixes, congratulations.  The other reason I don't like working with other programmers is if you do something but don't do it their way, they turn into douches.  Working alone I can do things however I want, and I don't need to be mocked for it.  I took the high road and tried to share it with more people than just myself.  I ran into a wall of contempt.  Figures.



                #8 Arcon

                Arcon

                  Advanced Member

                • Windower Staff
                • 1189 posts
                • LocationMunich, Germany

                Posted 06 April 2015 - 06:28 PM

                You've suceeded in deterring me from submitting future bug fixes, congratulations.

                 

                Thank you, I try very hard.



                #9 ___

                ___

                  Advanced Member

                • Members
                • PipPipPip
                • 40 posts

                  Posted 06 April 2015 - 06:36 PM

                  You certainly haven't tried very hard to be accomdating, aggression over altruism is all you had to state.  You're not suppoosed to take Groupthink to heart you know, it's a warning not a model.  Since I see no compromise, I've articulated myself quite clearly and I'm only met with aggression, I'll leave it at that as all that can happen from here is tired escalation.






                  1 user(s) are reading this topic

                  0 members, 1 guests, 0 anonymous users