Jump to content


Photo

azuresets setting spells randomly


    11 replies to this topic

    #1 Fynlar

    Fynlar

      Newbie

    • Members
    • Pip
    • 6 posts

      Posted 01 May 2016 - 09:40 AM

      According to the "date modified" parameter on my azuresets.lua file, it was modified at some point today when I opened up windower... which I'm not sure if it means anything significant, but if I had to guess I would say the addon has been changed somehow.

       

      Today I've started noticing a weird behavior of the addon -- instead of following the set spell order that I have listed in my set when equipping a set using the addon, it seemingly just equips the spells into whatever slots it likes now, completely ignoring the preset order I have it saved as in the settings.xml

       

      It does at least still equip all of the spells in the set, but with the order being completely wrong, this is pretty bad for both level cap scenarios and for manually adjusting a few spells on the fly.

       

      In addition to this issue, it also seems to take the addon several seconds longer to equip a set than it did before.  I could understand a change like this being done if it made the addon do its work faster, but giving up performance AND functionality feels like two steps backward instead, and I imagine this wasn't intentional :/

       

      Is there any reason for this change / a fix in the works?

       

      EDIT: For clarification, there was no unexpected behavior from this addon prior to today, nor had I been doing any sort of manual tweaking or installing/uninstalling of azuresets files aside from whatever the windower launcher may or may not have done upon startup.



      #2 Iryoku

      Iryoku

        Advanced Member

      • Windower Staff
      • 488 posts

        Posted 01 May 2016 - 10:40 AM

        If I had to guess, this change in behavior was caused by Pull Request 1414. It was merged into the development branch 23 days ago, but only got pushed out to everyone else yesterday morning. The new behavior only changes the spells that are different between the current set and the new set. The point is that the old behavior would cause the unnecessary loss of the dual wield trait (all other traits, too, but dual wield was the impetus for this change), forcibly unequipping the off-hand weapon and causing TP to reset. The reason change time may have increased is because, under the new behavior, spells have to be unset one at a time before new spells can be set.

         

        I don't expect this change to be reverted.


        • Fynlar likes this

        #3 Fynlar

        Fynlar

          Newbie

        • Members
        • Pip
        • 6 posts

          Posted 01 May 2016 - 11:36 AM

          That's... very unfortunate :/  Is there no way the user can adjust this on their end?  Haphazardly equipping spells and ignoring set orders when set order DOES actually matter as far as game mechanics go is really not something this addon should be doing...

           

          Thanks for the prompt response, anyhow



          #4 Lewis

          Lewis

            Member

          • Members
          • PipPip
          • 13 posts

            Posted 02 May 2016 - 10:10 AM

            The restart today fixed the problem that i had. or i thought it did 



            #5 Lewis

            Lewis

              Member

            • Members
            • PipPip
            • 13 posts

              Posted 02 May 2016 - 03:06 PM

              Hum it's taking 40~50s to swap spells now instead of 8~10s i think i will replace the new lua file with the old 1 because i liked how it worked much better before yesterdays update.



              #6 Iryoku

              Iryoku

                Advanced Member

              • Windower Staff
              • 488 posts

                Posted 03 May 2016 - 02:41 AM

                Pull Request 1434 was just submitted today (by the same author as PR 1414) which makes it possible to choose which behavior to use as a global default, and to override that default with an optional argument to the set command. It's still being code reviewed, but we'll try to get this pushed out to everyone ASAP.



                #7 Fynlar

                Fynlar

                  Newbie

                • Members
                • Pip
                • 6 posts

                  Posted 07 May 2016 - 12:38 AM

                  Awesome, thanks a bunch!



                  #8 Fynlar

                  Fynlar

                    Newbie

                  • Members
                  • Pip
                  • 6 posts

                    Posted 11 May 2016 - 11:17 AM

                    Pull Request 1434 was just submitted today (by the same author as PR 1414) which makes it possible to choose which behavior to use as a global default, and to override that default with an optional argument to the set command. It's still being code reviewed, but we'll try to get this pushed out to everyone ASAP.

                     

                    I see that the addon has been updated with this new feature, and it does work (solving the issue of the addon taking much longer than before to set the spells), but unfortunately it's still doing the same behavior of setting the spells seemingly however it likes, rather than in the order specified in the set :<



                    #9 Lewis

                    Lewis

                      Member

                    • Members
                    • PipPip
                    • 13 posts

                      Posted 11 May 2016 - 06:23 PM

                      I have just been using a pre azuresets lua file that i just repaste over any updated version and it just works how it use to.

                       

                      Here is a link to the pre pre update version 

                       

                      https://www.dropbox....resets.lua?dl=0



                      #10 Fynlar

                      Fynlar

                        Newbie

                      • Members
                      • Pip
                      • 6 posts

                        Posted 12 May 2016 - 12:47 AM

                        Cool, I didn't know about where to find such a thing.  Thanks a bunch!



                        #11 sdahlka

                        sdahlka

                          Advanced Member

                        • Members
                        • PipPipPip
                        • 324 posts

                          Posted 12 May 2016 - 01:20 AM

                          i see no point in worrying about the order if the spells when you set them as it does not matter



                          #12 Fynlar

                          Fynlar

                            Newbie

                          • Members
                          • Pip
                          • 6 posts

                            Posted 13 May 2016 - 12:41 AM

                            i see no point in worrying about the order if the spells when you set them as it does not matter

                             

                            It actually does, because when you get level capped spells are removed according to your maximum spell limit based on the order you set them in (BLU happens to be quite effective in level capped content, therefore this IS a concern for me), plus it makes things inconvenient for manually swapping a spell or two in to replace specific others when you have to search for the spells.  I am very used to the order mine are set in and therefore I know exactly where to find certain spells to be replaced.

                             

                            Simply put, if the addon very clearly states that, say, Erratic Flutter goes in "slot 01", I shouldn't be finding it in slot 12 after equipping the set.  To me that's just common sense.






                            1 user(s) are reading this topic

                            0 members, 1 guests, 0 anonymous users