Jump to content


Photo

Area of effect and pretarget issue?

Started by agnosgnosia , Sep 21 2015 11:17 AM
pretargetarea of effect

Best Answer Iryoku , 22 September 2015 - 02:07 PM

Ah, that issue, yeah. Unfortunately it's not exposed to plugins either (which is why it can't be added to LuaCore). I've completely mapped out that value, but adding it to the plugin API is a breaking change, and requires rebuilding every plugin, even the ones that don't use it, so it keeps getting pushed off. Until now it's only caused some minor inconvenience for Byrth trying to work around its absence, but if it's affecting game features, then it's going to have to get added.

Go to the full post


    5 replies to this topic

    #1 agnosgnosia

    agnosgnosia

      Advanced Member

    • Members
    • PipPipPip
    • 30 posts

      Posted 21 September 2015 - 11:17 AM

      When I'm doing my cor rolls, having the blue graphic that shows who my rolls will hit is incredibly useful. However, when I subtarget myself from a macro, the blue graphic showing who it will hit doesn't show. I checked out debugmode and it says 'entering pretarget. I'm guessing this is the offending function (or whatever it's called in lua format). 

       

      Can I turn off pretarget without breaking these luas? Is there any way I can make it so I can see the blue aoe graphic? Any help would be appreciated.

       

      Edit: I copied and pasted the search finds from all the luas that had pretarget in them. These are all Motes luas. They are unchanged from when I downloaded them.

       

       

       C:\Program Files (x86)\Windower4\addons\GearSwap\flow.lua (12 hits)
      Line 35: ---- ts - index of command_registry or nil for pretarget/commands
      Line 40: ---- pretarget : empty string to blank packet or full string
      Line 48:     table.reassign(_global,command_registry[ts] or {pretarget_cast_delay = 0,precast_cast_delay=0,cancel_spell = false})
      Line 106:     if type(swap_type) == 'string' and (swap_type == 'pretarget' or swap_type == 'filtered_action') then -- Target may just have been changed, so make the ind now.
      Line 191:         if swap_type == 'pretarget' then
      Line 224:                             msg.debugging("Unable to create a packet for this command because the target is still invalid after pretarget ("..storedcommand..' '..val1.target.raw..")")
      Line 248:                     if command_registry[ts].pretarget_cast_delay == 0 then
      Line 251:                         windower.send_command('@wait '..command_registry[ts].pretarget_cast_delay..';lua i '.._addon.name..' pretarget_delayed_cast '..ts)
      Line 251:                         windower.send_command('@wait '..command_registry[ts].pretarget_cast_delay..';lua i '.._addon.name..' pretarget_delayed_cast '..ts)
      Line 304: --Name: pretarget_delayed_cast(ts)
      Line 312: function pretarget_delayed_cast(ts)
      Line 317:         msg.debugging("Bad index passed to pretarget_delayed_cast")
       
        C:\Program Files (x86)\Windower4\addons\GearSwap\statics.lua (1 hits)
      Line 198: _global.pretarget_cast_delay = 0
        C:\Program Files (x86)\Windower4\addons\GearSwap\helper_functions.lua (5 hits)
      Line 597: --Name: filter_pretarget(spell)
      Line 599: ----    at pretarget.
      Line 606: function filter_pretarget(spell)
      Line 714:                 3) + (v.pretarget_cast_delay or 0) + (v.precast_cast_delay or 0))
      Line 750:     rawset(self,ts,{pretarget_cast_delay=0, precast_cast_delay=0, spell=sp, timestamp=ts})
        C:\Program Files (x86)\Windower4\addons\GearSwap\refresh.lua (1 hits)
      Line 175:     _global.pretarget_cast_delay = 0
       
        C:\Program Files (x86)\Windower4\addons\GearSwap\user_functions.lua (6 hits)
      Line 63:     if _global.current_event ~= 'precast' and _global.current_event ~= 'pretarget' and _global.current_event ~= 'filtered_action' then
      Line 64:         error('\nGearSwap: cancel_spell() is only valid in the precast, pretarget, or filtered_action functions', 2)
      Line 76:     if _global.current_event ~= 'pretarget' then
      Line 77:         error('\nGearSwap: change_target() is only valid in the pretarget function', 2)
      Line 92:     if _global.current_event ~= 'precast' and _global.current_event ~= 'pretarget' then
      Line 93:         error('\nGearSwap: cast_delay() is only valid in the precast and pretarget functions', 2)
        C:\Program Files (x86)\Windower4\addons\GearSwap\triggers.lua (2 hits)
      Line 116:             if filter_pretarget(spell) then
      Line 137:                     return equip_sets('pretarget',-1,spell)
      Search "entering" (2 hits in 1 files)
        C:\Program Files (x86)\Windower4\addons\GearSwap\flow.lua (2 hits)
      Line 84:         msg.debugging("Entering "..swap_type)
      Line 86:         msg.debugging("Entering User Event "..tostring(swap_type))
      Search "Entering pretarget" (0 hits in 0 files)
      Search "pretarget" (27 hits in 6 files)
        C:\Program Files (x86)\Windower4\addons\GearSwap\flow.lua (12 hits)
      Line 35: ---- ts - index of command_registry or nil for pretarget/commands
      Line 40: ---- pretarget : empty string to blank packet or full string
      Line 48:     table.reassign(_global,command_registry[ts] or {pretarget_cast_delay = 0,precast_cast_delay=0,cancel_spell = false})
      Line 106:     if type(swap_type) == 'string' and (swap_type == 'pretarget' or swap_type == 'filtered_action') then -- Target may just have been changed, so make the ind now.
      Line 191:         if swap_type == 'pretarget' then
      Line 224:                             msg.debugging("Unable to create a packet for this command because the target is still invalid after pretarget ("..storedcommand..' '..val1.target.raw..")")
      Line 248:                     if command_registry[ts].pretarget_cast_delay == 0 then
      Line 251:                         windower.send_command('@wait '..command_registry[ts].pretarget_cast_delay..';lua i '.._addon.name..' pretarget_delayed_cast '..ts)
      Line 251:                         windower.send_command('@wait '..command_registry[ts].pretarget_cast_delay..';lua i '.._addon.name..' pretarget_delayed_cast '..ts)
      Line 304: --Name: pretarget_delayed_cast(ts)
      Line 312: function pretarget_delayed_cast(ts)
      Line 317:         msg.debugging("Bad index passed to pretarget_delayed_cast")
       
        C:\Program Files (x86)\Windower4\addons\GearSwap\statics.lua (1 hits)
      Line 198: _global.pretarget_cast_delay = 0
        C:\Program Files (x86)\Windower4\addons\GearSwap\helper_functions.lua (5 hits)
      Line 597: --Name: filter_pretarget(spell)
      Line 599: ----    at pretarget.
      Line 606: function filter_pretarget(spell)
      Line 714:                 3) + (v.pretarget_cast_delay or 0) + (v.precast_cast_delay or 0))
      Line 750:     rawset(self,ts,{pretarget_cast_delay=0, precast_cast_delay=0, spell=sp, timestamp=ts})
       
        C:\Program Files (x86)\Windower4\addons\GearSwap\refresh.lua (1 hits)
      Line 175:     _global.pretarget_cast_delay = 0
       
        C:\Program Files (x86)\Windower4\addons\GearSwap\user_functions.lua (6 hits)
      Line 63:     if _global.current_event ~= 'precast' and _global.current_event ~= 'pretarget' and _global.current_event ~= 'filtered_action' then
      Line 64:         error('\nGearSwap: cancel_spell() is only valid in the precast, pretarget, or filtered_action functions', 2)
      Line 76:     if _global.current_event ~= 'pretarget' then
      Line 77:         error('\nGearSwap: change_target() is only valid in the pretarget function', 2)
      Line 92:     if _global.current_event ~= 'precast' and _global.current_event ~= 'pretarget' then
      Line 93:         error('\nGearSwap: cast_delay() is only valid in the precast and pretarget functions', 2)
       
        C:\Program Files (x86)\Windower4\addons\GearSwap\triggers.lua (2 hits)
      Line 116:             if filter_pretarget(spell) then
      Line 137:                     return equip_sets('pretarget',-1,spell)

      #2 Iryoku

      Iryoku

        Advanced Member

      • Windower Staff
      • 488 posts

        Posted 21 September 2015 - 03:39 PM

        None of those are Mote's files, they're all core GearSwap files. Mote contributed a lot to GearSwap, so he's all over the commit history. Mote's files live in addons\GearSwap\libs. Someone who's more familiar with GearSwap's internals will need to chime in to answer your question though; I'll see if I can drag Byrth over here.


        • agnosgnosia likes this

        #3 agnosgnosia

        agnosgnosia

          Advanced Member

        • Members
        • PipPipPip
        • 30 posts

          Posted 22 September 2015 - 02:07 AM

          Not sure if this will help but I have these in my gearswap folder. I also have motes stuff in my libs folder.

          equip_processing.lua

          export.lua

          flow.lua

          gearswap.lua

          helper_functions.lua,

          refresh.lua
          statics.lua
          targets.lua
          triggers.lua
          user_functions.lua
          validate.lua  

          #4 trv

          trv

            Advanced Member

          • Members
          • PipPipPip
          • 34 posts

            Posted 22 September 2015 - 02:19 AM

            It has to do with a flag in the outgoing text event that isn't exposed in Luacore. Briefly touched on at some point in here, but not really in any more detail.


            #5 Iryoku

            Iryoku

              Advanced Member

            • Windower Staff
            • 488 posts

              Posted 22 September 2015 - 02:07 PM   Best Answer

              Ah, that issue, yeah. Unfortunately it's not exposed to plugins either (which is why it can't be added to LuaCore). I've completely mapped out that value, but adding it to the plugin API is a breaking change, and requires rebuilding every plugin, even the ones that don't use it, so it keeps getting pushed off. Until now it's only caused some minor inconvenience for Byrth trying to work around its absence, but if it's affecting game features, then it's going to have to get added.


              #6 agnosgnosia

              agnosgnosia

                Advanced Member

              • Members
              • PipPipPip
              • 30 posts

                Posted 23 September 2015 - 12:41 AM

                If it affects every single plugin by changing it I can see why it would get pushed off. Like momma always said, "Beggars can't be choosers.". Thanks for doing what you guys do!


                Back to Support


                1 user(s) are reading this topic

                0 members, 1 guests, 0 anonymous users