Jump to content


New Addon closetCleaner, where do I go from here...

    2 replies to this topic

    #1 Brimstone



    • Members
    • Pip
    • 2 posts

      Posted 26 February 2017 - 09:54 PM

      So I wrote an addon that looks through your inventory and whatever you tell it are your active gearswap files and reports the amount of times pieces of gear are used in your sets.



      More details in this thread as well: http://www.ffxiah.co...aner-new-addon/


      Its been suggested I come here and make this more official, so I guess I have a couple questions:

      1. I bastardized a bunch of gearswap and/or organizer functions to get it to work, as such would this exist better as a subset there rather than a stand alone addon?

      2. And I guess depending on the above what do I do now?


      Ideas I had for improvements where potentially:

      1. dynamically size the report columns

      2. allow the report to be customized (change justifications/columns)

      3. print a column of 'what can be done with this' (ie AH, mule, storage slip, trade for voucher, drop it, bazaar etc...)


      1 and 2 aren't difficult I just thus far felt the effort/reword ratio isn't there.

      #3 I think would be nice, but I don't know where to get that data, I don't think its in resources.


      All inputs are welcome (either feature suggestions, bug fixes, or actual coding help)

      #2 Iryoku


        Advanced Member

      • Windower Staff
      • 488 posts

        Posted 04 March 2017 - 02:41 AM

        Reusing code from other addons is perfectly fine, as long as you give credit (it's part of the reason we require all addons to be licensed under the BSD license). As for getting your addon listed in the Windower launcher, here's a rough outline of the steps.

        1. Make sure all of the .lua files for your addon are properly licensed under the BSD license. We have instructions for how to do this on our GitHub repository.
        2. Create a fork of the Windower/Lua repository on GitHub, by clicking the "Fork" button at the top right of the page.
        3. Clone the repository using which ever git client you prefer.
        4. Create and check out a new branch for you to work on while you add the addon to your fork. (git checkout -b branch-name from the command line)
        5. Create a new directory for your addon inside the addons directory of the repo.
        6. Edit the addons/addons.xml file to include an entry for you addon. Note: we won't accept the pull request if you do not fill out all of the fields.
        7. Commit your changes to the repository and push them to GitHub.
        8. Go to your fork on GitHub and click on the "New pull reqest" button on the top left. Make sure that you have the "dev" branch on Windower/Lua selected for the base fork (left) and your new branch on your fork selected for the head fork (right), and click "Create pull request".

        Once you've completed the steps above, one of us (probably Arcon) will review the pull request and make sure everything is in order. If there are any changes that need to be made we'll leave a comment on the PR explaining the problem. You can then make the requested changes to your branch and push them to GitHub. The PR will automatically be updated and an email will be sent to us to let us know. The changes will be reviewed again and that cycle will repeat until we feel there are no more issues at which point the PR will be merged.


        Initially it will be merged into the development branch, but eventually it will be merged into the live branch and everyone will see it.

        #3 Brimstone



        • Members
        • Pip
        • 2 posts

          Posted 24 June 2017 - 01:31 PM

          Thank you  for that I finally got off my lazy duff and did everything. So you should see the pull request.


          It may be better as part of gearswap instead of a stand alone addon, but it does really matter to me.

          1 user(s) are reading this topic

          0 members, 1 guests, 0 anonymous users