Jump to content


Photo

LatentChecker


    12 replies to this topic

    #1 Sabishii Kouen

    Sabishii Kouen

      Advanced Member

    • Members
    • PipPipPip
    • 33 posts

      Posted 11 January 2015 - 08:13 PM

      I was working on a latent weapon (dagger of trials), and when I loaded up LatentChecker, and hit lc run it gave an error on line 78 referring to a "nil value of variable l"

       

      I looked at latentchecker.lua, and looked at line 78:

       

      args = l{...}
      

      That L shouldn't be there, it looks like the author intended to either leave out the L or type in "Local args = {. . .}"

       

      I took out the L, and the addon worked, so I just wanted to let the dev team know there was a mistake in this coding, so they can fix it for other people.



      #2 Iryoku

      Iryoku

        Advanced Member

      • Windower Staff
      • 488 posts

        Posted 11 January 2015 - 08:24 PM

        Just so you know, anyone can submit fixes like this by submitting a pull request to our GitHub repository. Just sign up for a free account (if you don't already have one), then click Fork at the top of the repository. This will create a personal copy of the repository for you to work on. Now check in any fixes you would like to make (either using the web interface on GitHub or using a git client to clone the repository to your PC). Once you're done, create a new pull request, everyone on the dev team will be notified by email, and one of us will review the changes and if everything looks ok it will be merged into the development branch for testing before going live.



        #3 Arcon

        Arcon

          Advanced Member

        • Windower Staff
        • 1189 posts
        • LocationMunich, Germany

        Posted 11 January 2015 - 08:26 PM

        That l is supposed to be upper cased:

           local args = L{...}


        #4 sdahlka

        sdahlka

          Advanced Member

        • Members
        • PipPipPip
        • 324 posts

          Posted 12 January 2015 - 01:17 AM

          here is the fixed file

          sorry i should have testest it before i pushed it and thx for the error report



          #5 Rihassa

          Rihassa

            Newbie

          • Members
          • Pip
          • 3 posts

            Posted 14 January 2015 - 07:43 AM

            sorry newbie here where do I retrieve the count from don't see a value anywhere ? 



            #6 Arcon

            Arcon

              Advanced Member

            • Windower Staff
            • 1189 posts
            • LocationMunich, Germany

            Posted 14 January 2015 - 02:40 PM

            It should print it into the Windower console.



            #7 Rihassa

            Rihassa

              Newbie

            • Members
            • Pip
            • 3 posts

              Posted 14 January 2015 - 06:44 PM

              nope all I get is starting then done no numbers try with and without the unequip on 



              #8 Arcon

              Arcon

                Advanced Member

              • Windower Staff
              • 1189 posts
              • LocationMunich, Germany

              Posted 14 January 2015 - 08:42 PM

              Are you using it right? After you load it you need to use "//latentchecker run" to get it to work. You also need to have room to move the item to in any other bag that is accessible from where you are. So if you're in the field and all your bags are full it won't work.



              #9 Rihassa

              Rihassa

                Newbie

              • Members
              • Pip
              • 3 posts

                Posted 14 January 2015 - 09:42 PM

                ok empty spots in other bags yes

                 

                loaded and reloaded addon yes

                 

                toggled unequip yes 

                 

                manually moved pole of trials to other bags yes 

                 

                every different bag yes 

                 

                still no numbers displaying still getting starting then done and no numbers with unequip on removes staff perfectly so addon is working would my black console window mess up it displaying ? 



                #10 sdahlka

                sdahlka

                  Advanced Member

                • Members
                • PipPipPip
                • 324 posts

                  Posted 15 January 2015 - 02:57 PM

                  you do not need to move it it does it on its own and will return it to your invitory

                   

                  if you have the item in your wardrobe it wont work



                  #11 Kenshi

                  Kenshi

                    Advanced Member

                  • Members
                  • PipPipPip
                  • 334 posts

                    Posted 27 January 2015 - 07:13 PM

                    Im having problems with this addon as well it will just print Starting and inmediately print done, I can't get it to even move the weapon (not using wardrobe).



                    #12 Kenshi

                    Kenshi

                      Advanced Member

                    • Members
                    • PipPipPip
                    • 334 posts

                      Posted 27 January 2015 - 10:02 PM

                      ok found the problem, there is a space at the end in "pole of trials " so its not finding the weapon. I'll post the issue on github.



                      #13 Arcon

                      Arcon

                        Advanced Member

                      • Windower Staff
                      • 1189 posts
                      • LocationMunich, Germany

                      Posted 28 January 2015 - 10:02 PM

                      It has been fixed since.






                      1 user(s) are reading this topic

                      0 members, 1 guests, 0 anonymous users